Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow overwriting of 'gitlab_runner_install_directory' #339

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Feature: Allow overwriting of 'gitlab_runner_install_directory' #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9faf353
feat: move 'gitlab_runner_install_directory' into defaults to allow o…
nicoklaus Jul 30, 2024
dd319a1
feat: use if condition to set install directory under windows
nicoklaus Dec 4, 2024
5f33c5c
Merge branch 'master' into feature-overwriting-installation-directory
nicoklaus Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
# This variable should not be modified usually as it depends on the gitlab_runner_wanted_version variable
gitlab_runner_wanted_tag: "{{ 'latest' if gitlab_runner_wanted_version == 'latest' else ('v' + gitlab_runner_wanted_version) }}"

# Override the install directory under Windows via host variables etc. (Default: c:/gitlab-runner)
gitlab_runner_custom_install_directory: ""
gitlab_runner_install_directory: "{{ gitlab_runner_default_install_directory if (gitlab_runner_custom_install_directory == '') else gitlab_runner_custom_install_directory }}"

Check failure on line 16 in defaults/main.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

yaml[line-length] 

Line too long (174 > 160 characters)

# Overridden based on platform
gitlab_runner_config_file: "{{ __gitlab_runner_config_file_system_mode if gitlab_runner_system_mode else __gitlab_runner_config_file_user_mode }}"
gitlab_runner_config_file_location: "{{ gitlab_runner_config_file | dirname }}"
Expand Down
3 changes: 2 additions & 1 deletion vars/Windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ gitlab_runner_download_url: https://gitlab-runner-downloads.s3.amazonaws.com/{{
# working directory for gitlab runner. defaults to config file directory
gitlab_runner_working_directory: ""

gitlab_runner_install_directory: c:/gitlab-runner/
gitlab_runner_default_install_directory: c:/gitlab-runner/

gitlab_runner_config_file_location: "{{ gitlab_runner_install_directory }}"
gitlab_runner_config_file: "{{ gitlab_runner_config_file_location }}/config.toml" # on Windows

Expand Down
Loading