Skip to content

Commit

Permalink
powerpc: fix early exit from udev on hotplug event for fadump
Browse files Browse the repository at this point in the history
Sysfs /sys/kernel/fadump/hotplug_ready contains 1 if hotplug is
supported by fadump.

Now to exit early the RUN command should grep 0 from
/sys/kernel/fadump/hotplug_ready instead of 1.

Fix it by updating RUN command.

Fixes: b4e3d37 ("fadump/udev: do not re-register fadump if kernel hotplug ready")
Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
  • Loading branch information
sourabhjains authored and coiby committed Jan 10, 2025
1 parent 3c7b8f7 commit 679a1c5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion 98-kexec.rules.ppc64
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ LABEL="kdump_reload_mem"

# Don't re-register fadump if /sys/kernel/fadump/hotplug_ready sysfs is set to 1.

RUN+="/bin/sh -c '/usr/bin/systemctl is-active kdump.service || exit 0; ! test -f /sys/kernel/fadump/hotplug_ready || cat /sys/kernel/fadump/hotplug_ready | grep 1 || exit 0; /usr/bin/systemd-run --quiet --no-block /usr/lib/udev/kdump-udev-throttler'"
RUN+="/bin/sh -c '/usr/bin/systemctl is-active kdump.service || exit 0; ! test -f /sys/kernel/fadump/hotplug_ready || cat /sys/kernel/fadump/hotplug_ready | grep 0 || exit 0; /usr/bin/systemd-run --quiet --no-block /usr/lib/udev/kdump-udev-throttler'"

GOTO="kdump_reload_end"

Expand Down

0 comments on commit 679a1c5

Please sign in to comment.