Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update coverage #66

Closed
wants to merge 32 commits into from
Closed

update coverage #66

wants to merge 32 commits into from

Conversation

reuvenperetz
Copy link
Owner

@reuvenperetz reuvenperetz commented Apr 14, 2024

Pull Request Description:

Improve coverage:

  • Raise threshold test to 97%
  • Add "no cover" in cases of "internal" errors, some "repr" methods, and imports that are dependent on the framework version.
  • Remove parts that are unused: identity_wrapper, _generate_images_batch
  • Fix pytorch_device_config to return valid for "CPU" and add tests.
  • Fix lut_fake_quant to use nbits and add tests.
  • Add tests to edge matcher, logger, torch_utils, activation quantization functions, immutable class, scheduler step keras optimizer.
  • Use MP for activations in tensorboard test.
  • Fix name of concat threshold test to have prefix "test_".
  • Add test for onnx metadata.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant