Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support v12 alpha #76

Merged
merged 6 commits into from
Nov 30, 2024
Merged

Add support v12 alpha #76

merged 6 commits into from
Nov 30, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Nov 29, 2024

  • Allow selection of ReScript 12 alpha 5 and higher
  • Skips selection of ReScript Core
  • Updates rescript.json accordingly

@cknitt
Copy link
Member

cknitt commented Nov 29, 2024

@nojaf Nice work! Thanks a lot!

One thing: 12.0.0-alpha.5 is now the default selection. Could you make it so that the default selection stays on the latest 11.1.x?

@nojaf
Copy link
Contributor Author

nojaf commented Nov 29, 2024

@cknitt
Yup, done!

src/RescriptVersions.res Outdated Show resolved Hide resolved
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@cknitt cknitt merged commit 5ddbb65 into rescript-lang:master Nov 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants