Error callback support #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,10 +108,12 @@ define(['coffee-script'], function (CoffeeScript) { | |||
| } | |||
| //Make sure we return a JavaScript string and not a Java string. | |||
| content = String(stringBuffer.toString()); //String | |||
| } catch (err) { | |||
| errback(err); | |||
There was a problem hiding this comment.
Seems like this should do an if (errback) { } and if not not, then just rethrow.
|
In addition to the inline comments, it looks like the node definition for fetchText would need to be modified -- fs.readFileSync could throw. Also there is a try/catch around CoffeeScript.compile() that should take into account calling an errback if available. Closing for now, as I think it needs more work, and want to triage open issues, but feel free to post an update and we can reopen as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #39.