fix(dracut-functions): avoid awk in get_maj_min() #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reason: performance enhancement |
The `get_maj_min()` cache lookup is commonly used
across many flows. While `awk` should be available,
some highly constrained environments may not have it.
A second call to `grep` can provide the same behaviour
without adding a dependnecy.
Lines in the cache will be of the form "/dev/sda2 8:2".
`awk '{print $NF}'` returns the last word of a matching line. Since
the initial matching regex is so specific a second call to grep can
easily extract the last word.
(cherry picked commit ec7efd5)
Related: RHEL-47145
pvalena
force-pushed
the
rhel10-get_maj_min
branch
from
22eae90 to
9b94bc7
Compare
|
Easyfix, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_maj_min()cache lookup is commonly usedacross many flows. While
awkshould be available,some highly constrained environments may not have it.
A second call to
grepcan provide the same behaviourwithout adding a dependnecy.
Lines in the cache will be of the form "/dev/sda2 8:2".
awk '{print $NF}'returns the last word of a matching line. Sincethe initial matching regex is so specific a second call to grep can
easily extract the last word.
(cherry picked commit ec7efd5)
Related: RHEL-47145
(We've rebased anyway.)