Add boot storm workloads: Windows10/ Windows11/ Windows Server 2022 #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebattat
force-pushed
the
add_bootstorm_windows11
branch
from
0757b62 to
97c9edf
Compare
jeniferh
approved these changes
Oct 26, 2023
RobertKrawitz
approved these changes
Oct 26, 2023
| run: | | ||
| build=$(pip freeze | grep benchmark-runner | sed 's/==/=/g') | ||
| build_version="$(cut -d'=' -f2 <<<"$build")" | ||
| echo '>>>>>>>>>>>>>>>>>>>>>>>>>> Start E2E workload: ${{ matrix.workload }} >>>>>>>>>>>>>>>>>>>>>>>>>>' | ||
| scp -r "$RUNNER_PATH/.kube/config" provision:"$CONTAINER_KUBECONFIG_PATH" | ||
| # SCALE: Run vdbench/ bootstorm | ||
| if [[ '${{ matrix.workload }}' == 'vdbench_pod_scale' || '${{ matrix.workload }}' == 'vdbench_kata_scale' || '${{ matrix.workload }}' == 'vdbench_vm_scale' || '${{ matrix.workload }}' == 'bootstorm_vm_scale' || '${{ matrix.workload }}' == 'windows_vm_scale' ]] | ||
| if [[ '${{ matrix.workload }}' == 'vdbench_pod_scale' || '${{ matrix.workload }}' == 'vdbench_kata_scale' || '${{ matrix.workload }}' == 'vdbench_vm_scale' || '${{ matrix.workload }}' == 'bootstorm_vm_scale' || '${{ matrix.workload }}' == 'windows_vm_windows_server_2019_scale' || '${{ matrix.workload }}' == 'windows_vm_windows11_scale' ]] |
There was a problem hiding this comment.
It would be good to clean this up some time so we don't keep just adding more cases, although it might be a bit awkward...
There was a problem hiding this comment.
@RobertKrawitz, You right fixed it.
ebattat
force-pushed
the
add_bootstorm_windows11
branch
from
97c9edf to
4a4030c
Compare
ebattat
force-pushed
the
add_bootstorm_windows11
branch
2 times, most recently
from
f32ca2c to
d00339a
Compare
|
@jeniferh, updated vm yaml template according to your recommendation. |
RobertKrawitz
requested changes
Oct 30, 2023
Comment on lines
113
to
114
| - 'windows_vm_scale_windows_server_2019' | ||
| - 'windows_vm_scale_windows11' |
There was a problem hiding this comment.
Ideally would be a separate option/environment variable to pick the desired OS, but I won't insist on that here.
ebattat
force-pushed
the
add_bootstorm_windows11
branch
from
e843018 to
33ec8bf
Compare
Thanks, template updates look great. |
ebattat
force-pushed
the
add_bootstorm_windows11
branch
from
e155a45 to
c695dd5
Compare
RobertKrawitz
requested changes
Oct 30, 2023
| then | ||
| case ${{ matrix.workload }} in |
There was a problem hiding this comment.
Should be
case '${{ matrix.workload }}' in
just in case there's ever a space (or something that results in the shell doing something with it) in the workload name.
ebattat
force-pushed
the
add_bootstorm_windows11
branch
from
f1b6a28 to
6a886e0
Compare
RobertKrawitz
approved these changes
Oct 31, 2023
RobertKrawitz
approved these changes
Oct 31, 2023
ebattat
force-pushed
the
add_bootstorm_windows11
branch
from
0153312 to
dfb8cab
Compare
ebattat
changed the title
|
@RobertKrawitz, I have added boot storm workloads: Windows10/ Windows11/ Windows Server 2022 |
ebattat
changed the title
ebattat
force-pushed
the
add_bootstorm_windows11
branch
from
2511f4a to
5a136ee
Compare
ebattat
changed the title
RobertKrawitz
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Adding new Windows11 scale workload:
For security reasons, all pull requests need to be approved first before running any automated CI