-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
item-12-147 #392
item-12-147 #392
Conversation
69e41a3
to
a858783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One item about the "no" designation, but I'd also like @SNiemann15 to review this before we move forward with it, since she's the expert on these product names.
@SNiemann15 can you PTAL?
@@ -18,6 +18,16 @@ | |||
|
|||
*See also*: | |||
|
|||
[[ibm-eserver-system-i]] | |||
==== image:images/yes.png[no] IBM eServer System i (noun) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want this to be a use it: no, then it has to be "no.png" here and the "use it" field has to be set to "no".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted, and thanks for reviewing. Updated.
a858783
to
81abfc5
Compare
Correct IBM eserver system i is also one of the previous names and shouldn't be used. Wikipedia gives a good overview of all the names (they are just missing the latest change to IBM Power) |
/lgtm |
Thanks for checking, @SNiemann15 . Would you be OK to add an approval tick to this PR; that is Files changed > Review changes > Approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Considerations
Recent IBM Cloud updates were made to the guide: #359 . The request for a usable
IBM eServer System i
term is no longer valid.Issue
Closes number 12 in #147
Preview link
See ibm-eserver-system-i and iSeries