CRC setup is reseted after closing its window #4411

[vrubezhny]

Fixes: #4411

[vrubezhny]

@lgrossma Could you please verify if this PR solves #4437 problem of having settings.json created like this:

{ 
  ...
  "openshiftToolkit.crcBinaryLocation": "~/projects/vscode-openshift-tools/crc/crc-linux-amd64/crc-linux-2.41.0-amd64/crc",   
  "openshiftToolkit": {
    ...
    "crcBinaryLocation": null,
    ...
  },
  ...
} 

Also I'm expecting this to solve #4413 and #4414

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 43.50%. Comparing base (da60441) to head (5f2bcd7).
Report is 493 commits behind head on main.

Files with missing lines	Patch %	Lines
src/webview/cluster/clusterViewLoader.ts	0.00%	10 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #4437       +/-   ##
===========================================
+ Coverage   32.37%   43.50%   +11.12%     
===========================================
  Files          85       98       +13     
  Lines        6505     8000     +1495     
  Branches     1349     1686      +337     
===========================================
+ Hits         2106     3480     +1374     
- Misses       4399     4520      +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vrubezhny]

Also, I've changed the crcNameServer setting to vscode.ConfigurationTarget.Global to align it to the rest of the CRC settings... I don't see any reason for it to be saved as a Workspace setting rather than a Global one.
Please open an issue if this setting is still to be saved as a Workspace setting

[datho7561]

From my testing, this works, and the code changes look good. I would be interested to see if it solves Lukas' problem

[lgrossma]

Works great now! thx