Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherrypick missing updates from main... #829

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Jan 2, 2025

What does this PR do?

chore: cherrypick missing updates from main -> 1.4

  • fix for ./artifacts/rhdh-plugins-reference/keycloak/keycloak-plugin-admin.adoc (undefined variable keycloak-version)
  • fix for running python scripts (presuming that ./modules/release-notes/single-source-release-notes.py needs this)

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jan 2, 2025

@themr0c themr0c merged commit 58d8b6a into release-1.4 Jan 2, 2025
3 checks passed
@themr0c themr0c deleted the missing-attribs-and-reqs branch January 2, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants