Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional debugging to test command execution #825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgwest
Copy link
Collaborator

@jgwest jgwest commented Jan 17, 2025

What type of PR is this?
/kind code-refactoring

What does this PR do / why we need it:

I noticed that this test was failing in another PR:

�[91m�[1m[Fail] �[0m�[90mArgo CD metrics controller �[0m�[0mCheck if monitoring resources are created �[0m�[91m�[1m[It] Role is created �[0m
�[37m/go/src/github.com/redhat-developer/gitops-operator/test/e2e/argocd_metrics_test.go:42�[0m

However, it was not obvious why, because the output from oc is not printed in the failing case. This PR updates the command execution logic to output console stdout/stderr, so if this error occurs again we can know why.

Signed-off-by: Jonathan West <jonwest@redhat.com>
Copy link

openshift-ci bot commented Jan 17, 2025

@jgwest: The label(s) kind/code-refactoring cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind code-refactoring

What does this PR do / why we need it:

I noticed that this test was failing in another PR:

�[91m�[1m[Fail] �[0m�[90mArgo CD metrics controller �[0m�[0mCheck if monitoring resources are created �[0m�[91m�[1m[It] Role is created �[0m
�[37m/go/src/github.com/redhat-developer/gitops-operator/test/e2e/argocd_metrics_test.go:42�[0m

However, it was not obvious why, because the output from oc is not printed in the failing case. This PR updates the command execution logic to output console stdout/stderr, so if this error occurs again we can know why.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest
Copy link
Collaborator Author

jgwest commented Jan 17, 2025

/retest

failed to run bundle: error waiting for CSV to install: timed out waiting for the condition\n"
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-01-17T16:18:15Z"} ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant