Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable e2e tests #763

Conversation

trdoyle81
Copy link
Contributor

What type of PR is this?
/kind code-refactoring

What does this PR do / why we need it:
Non-kuttl test execution was removed in a previous PR as the 'printer' package is no longer available in "sigs.k8s.io/controller-runtime/pkg/envtest/printer"

Which issue(s) this PR fixes:

Fixes #?
GITOPS-4777

How to test changes / Special notes to the reviewer:
make test-e2e should now execute (without RunSpecsWithDefaultAndCustomReporters)

@trdoyle81 trdoyle81 force-pushed the GITOPS-4777-Enable-e2e-tests branch 2 times, most recently from 2b1b1ad to 63c28d0 Compare August 13, 2024 14:23
@trdoyle81
Copy link
Contributor Author

/retest

@trdoyle81 trdoyle81 force-pushed the GITOPS-4777-Enable-e2e-tests branch from 63c28d0 to ff35504 Compare August 20, 2024 08:04
@trdoyle81
Copy link
Contributor Author

/retest

@svghadi
Copy link
Member

svghadi commented Aug 20, 2024

/lgtm

@trdoyle81
Copy link
Contributor Author

/retest

@svghadi
Copy link
Member

svghadi commented Aug 22, 2024

/test v4.13-kuttl-parallel

Signed-off-by: Triona Doyle <trdoyle@redhat.com>
@trdoyle81 trdoyle81 force-pushed the GITOPS-4777-Enable-e2e-tests branch from ff35504 to 101f51a Compare August 27, 2024 08:38
@openshift-ci openshift-ci bot removed the lgtm label Aug 27, 2024
@varshab1210
Copy link
Member

LGTM, thanks

@varshab1210
Copy link
Member

/lgtm

@svghadi
Copy link
Member

svghadi commented Aug 27, 2024

/approve

Copy link

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varshab1210
Copy link
Member

/retest

@varshab1210
Copy link
Member

/test v4.14-e2e

Seems like n/w issue

@varshab1210
Copy link
Member

/test v4.14-kuttl-parallel

@varshab1210
Copy link
Member

/test v4.13-kuttl-parallel

@openshift-merge-bot openshift-merge-bot bot merged commit 45c82e3 into redhat-developer:master Aug 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants