updating ansible-lint #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdanielsson
commented
Jan 29, 2024
| ansible.builtin.shell: | | ||
| export PATH={{ os_path }} | ||
| set -o pipefail; |
There was a problem hiding this comment.
this change here (plus a bunch of other places this is just an example) would be the only concern that probably should be tested to ensure that the export path doesn't need to be first and we can set pipefail before it without issue. I do not think it should matter but in theory that is the main change that I could see breaking something unexpected
jeffmcutter
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #154 while I found it actually is probably working, it was out of date and I removed the pre-commit in favor of the Ansible-lint GitHub action that now seems to work better.