Mm feature/cluster settings #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorency
force-pushed
the
mm-feature/cluster-settings
branch
from
fe6549c to
9706e3b
Compare
mikemorency
force-pushed
the
mm-feature/cluster-settings
branch
from
e0743d6 to
00b9ce7
Compare
bardielle
reviewed
May 27, 2024
| ansible-core | ||
|
|
||
| # see the cluster_settings role README.md for an explanation on the <7.0.3 restriction | ||
| pyVmomi>=6.7,<7.0.3 |
There was a problem hiding this comment.
Not sure that's fine to do that...
What is the reason for that limitation?
There was a problem hiding this comment.
in 7.0.3 the VMWare team started returning an attribute as None when they previously left the attribute undefined. One module that this role uses only handles if the attribute is not defined, and throws an excpetion if its None
There was a problem hiding this comment.
| @@ -21,6 +21,6 @@ build_ignore: | |||
| - .idea | |||
| dependencies: { | |||
| "vmware.vmware_rest": ">=2.3.1", | |||
| "community.vmware": ">=4.2.0", | |||
| "community.vmware": ">=4.4.0", | |||
There was a problem hiding this comment.
Above you say 4.3.0.
There was a problem hiding this comment.
im not sure if you meant in the README.md or some other location, but I updated that reference to match this one (>=4.4.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding playbook and role to manage cluster settings for a vCenter cluster.
The user can optionally modify DRS, DRM, vCLS, HA, and vSAN settings on their cluster. Each group of settings can be configured, enabled/disabled, or omitted independently.
I added a playbook for general settings. I will add another playbook specifically for modifying HA status under another ticket.
I was not able to add integration tests for the vSAN settings due to a required SDK that can only be downloaded from VMWare with a customer login. Im making followup tickets to research ways around that