Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing docs and redundant vars #32

Merged
merged 3 commits into from
May 15, 2024
Merged

fix missing docs and redundant vars #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ffed83
fix missing docs and redundant vars
mikemorency May 13, 2024
98a7bce
update example and test playbooks
mikemorency May 13, 2024
90073df
integration test fix
mikemorency May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelogs/fragments/32__mm-bugfix__provision_virtual_esxi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
bugfixes:
- provision_virtual_esxi - Added missing variable documentation
- >-
provision_virtual_esxi - Role had redundant variable `provision_virtual_esxi_iso_path` that was left from a name refactor.
It was updated to match the new name. The new variable name `provision_virtual_esxi_datastore_iso_path` is already mandatory
10 changes: 9 additions & 1 deletion roles/provision_virtual_esxi/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ pyvomi
## Role Variables

### Auth
- **provision_virtual_esxi_hostname**:
- str, The name of the esxi or vcenter on which you want to deploy the vm. Required.

- **provision_virtual_esxi_username**:
- str, The username to use to authenticate to the esxi or vcenter on which you want to deploy the vm. Required.

Expand Down Expand Up @@ -64,6 +67,11 @@ pyvomi
- int, The number of vCPUs to assign to this VM.
- Default is 4

- **provision_virtual_esxi_boot_firmware**:
- str, The type of boot firmware that the VM should be configured to use. 'bios' or 'uefi'
- Default value is 'bios'


## Dependencies

- NA
Expand Down Expand Up @@ -97,7 +105,7 @@ pyvomi
- name: esxi-3
memory_mb: 24000
cpus: 12
provision_virtual_esxi_iso_path: "[nfs-datastore-iso] esxi_8.iso"
provision_virtual_esxi_datastore_iso_path: "[nfs-datastore-iso] esxi_8.iso"
```

License
Expand Down
2 changes: 1 addition & 1 deletion roles/provision_virtual_esxi/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
- name: Check VM Mandatory Variables Are Defined
ansible.builtin.assert:
that:
- provision_virtual_esxi_iso_path is defined
- provision_virtual_esxi_datastore_iso_path is defined
quiet: true
fail_msg: Variable must be set when using this role.
- name: Deploy New ESXi Hosts
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/targets/provision_virtual_esxi_test/vars/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ provision_virtual_esxi_port: 8989
provision_virtual_esxi_cluster: "DC0_C0"
provision_virtual_esxi_folder: "/DC0/vm"
provision_virtual_esxi_datacenter: "DC0"
provision_virtual_esxi_iso_path: ""
provision_virtual_esxi_datastore_iso_path: "[LocalDS_0] foo.iso"
provision_virtual_esxi_vms:
- name: esxi-1
- name: esxi-2
Expand Down
Loading