add sa to the deployment (#60)

* add sa to the deployment * add sa to the deployment * add sa to the deployment * add debug * add creating csv * add creating csv * add creating csv * add creating csv with apply * add creating csv with apply * add creating csv with apply * make install to the pre-main * make install to the pre-main * make install to the pre-main * make install to the pre-main * make install to the pre-main
redhat-best-practices-for-k8s · Jun 22, 2023 · 9e6a00d · 9e6a00d
1 parent 842458b
commit 9e6a00d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/.github/workflows/pre-main.yml b/.github/workflows/pre-main.yml
@@ -92,7 +92,10 @@ jobs:
 
       - name: Show controller's container image
         run: oc get pods -n "${TNF_TEST_NAMESPACE}" -o json | jq '.items[] | .spec.containers[] | select(.name == "manager") | .image'
-
+
+      - name: Run Make install to install dependencies
+        run: make install
+
       - name: Create operator cluster role.
         run: make addrole
 

diff --git a/Makefile b/Makefile
@@ -108,6 +108,7 @@ endif
 .PHONY: install
 install: manifests kustomize ## Install CRDs into the K8s cluster specified in ~/.kube/config.
 	$(KUSTOMIZE) build config/crd | kubectl apply -f -
+	kubectl apply -f service-account-for-crd-deployment.yaml
 
 .PHONY: uninstall
 uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified in ~/.kube/config. Call with ignore-not-found=true to ignore resource not found errors during deletion.

diff --git a/controllers/foo_controller.go b/controllers/foo_controller.go
@@ -46,7 +46,6 @@ func (r *FooReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
 		log.Error(err, "unable to fetch Foo")
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
-
 	log.Info("create deployment")
 	size := foo.Spec.Replicas
 	faleb := false
@@ -84,6 +83,7 @@ func (r *FooReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
 					},
 				},
 				Spec: corev1.PodSpec{
+					ServiceAccountName:            "role-sa-name",
 					TerminationGracePeriodSeconds: &tim,
 					AutomountServiceAccountToken:  &faleb,
 					Containers: []corev1.Container{{
@@ -170,6 +170,7 @@ func (r *FooReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
 			},
 		},
 	}
+
 	log.Info("after create deployment")
 	found := &appsv1.Deployment{}
 	errf := r.Get(context.TODO(), types.NamespacedName{

diff --git a/service-account-for-crd-deployment.yaml b/service-account-for-crd-deployment.yaml
@@ -0,0 +1,5 @@
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+  name: role-sa-name
+  namespace: tnf