Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-definitions update #5100

Merged
merged 1 commit into from
Dec 10, 2024
Merged

build-definitions update #5100

merged 1 commit into from
Dec 10, 2024

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

@rh-tap-build-team rh-tap-build-team bot commented Dec 10, 2024 •
edited
Loading

@openshift-ci openshift-ci bot requested review from chmeliik and tkdchen December 10, 2024 10:55
@rh-tap-build-team rh-tap-build-team bot force-pushed the build-definitions branch 2 times, most recently from 6760f85 to 06ddea9 Compare December 10, 2024 16:59
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 10, 2024

@rh-tap-build-team[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-upgrade-tests 0418ae5 link false /test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

arewm
arewm approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 10, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arewm, rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a203ffa into main Dec 10, 2024
5 of 6 checks passed
@arewm arewm deleted the build-definitions branch December 10, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arewm arewm arewm approved these changes

@chmeliik chmeliik Awaiting requested review from chmeliik

@tkdchen tkdchen Awaiting requested review from tkdchen

Assignees

@arewm arewm

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arewm