Skip to content

Commit

Permalink
Update example-workbench.yaml (#77)
Browse files Browse the repository at this point in the history
Updated to use latest workbench image as generated by RHOAI 2.13. 

- Solves SSL / TLS issue
- Updates to Python 3.11 workbench image
  • Loading branch information
carlmes authored Nov 18, 2024
1 parent 34d526b commit 1459e23
Showing 1 changed file with 25 additions and 12 deletions.
37 changes: 25 additions & 12 deletions tenants/ai-example/workbenches/base/example-workbench.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,28 @@ apiVersion: kubeflow.org/v1
kind: Notebook
metadata:
annotations:
notebooks.opendatahub.io/inject-oauth: 'true'
opendatahub.io/image-display-name: Minimal Python
notebooks.opendatahub.io/oauth-logout-url: ''
opendatahub.io/accelerator-name: ''
openshift.io/description: ''
notebooks.opendatahub.io/inject-oauth: "true"
opendatahub.io/image-display-name: Standard Data Science
notebooks.opendatahub.io/oauth-logout-url: ""
opendatahub.io/accelerator-name: ""
openshift.io/description: ""
openshift.io/display-name: example-workbench
notebooks.opendatahub.io/last-image-selection: 's2i-minimal-notebook:2024.1'
notebooks.opendatahub.io/last-image-selection: "s2i-generic-data-science-notebook:2024.2"
argocd.argoproj.io/sync-options: ServerSideApply=true
name: example-workbench
spec:
template:
spec:
affinity: {}
containers:
- name: example-workbench
image: 'image-registry.openshift-image-registry.svc:5000/redhat-ods-applications/s2i-minimal-notebook:2024.1'
image: "image-registry.openshift-image-registry.svc:5000/redhat-ods-applications/s2i-generic-data-science-notebook:2024.2"
resources:
limits:
cpu: '2'
cpu: "2"
memory: 8Gi
requests:
cpu: '1'
cpu: "1"
memory: 8Gi
readinessProbe:
failureThreshold: 3
Expand Down Expand Up @@ -54,9 +55,7 @@ spec:
--ServerApp.quit_button=False
--ServerApp.tornado_settings={"user":"user1","hub_host":"","hub_prefix":"/projects/ai-example-training"}
- name: JUPYTER_IMAGE
value: 'image-registry.openshift-image-registry.svc:5000/redhat-ods-applications/s2i-minimal-notebook:2024.1'
- name: PIP_CERT
value: /etc/pki/tls/custom-certs/ca-bundle.crt
value: "image-registry.openshift-image-registry.svc:5000/redhat-ods-applications/s2i-generic-data-science-notebook:2024.2"
- name: REQUESTS_CA_BUNDLE
value: /etc/pki/tls/custom-certs/ca-bundle.crt
- name: SSL_CERT_FILE
Expand All @@ -65,6 +64,8 @@ spec:
value: /etc/pki/tls/custom-certs/ca-bundle.crt
- name: GIT_SSL_CAINFO
value: /etc/pki/tls/custom-certs/ca-bundle.crt
- name: PIP_CERT
value: /etc/pki/tls/custom-certs/ca-bundle.crt
ports:
- containerPort: 8888
name: notebook-port
Expand All @@ -79,6 +80,10 @@ spec:
name: trusted-ca
readOnly: true
subPath: ca-bundle.crt
- mountPath: /etc/oauth/config
name: oauth-config
- mountPath: /etc/tls/private
name: tls-certificates
workingDir: /opt/app-root/src
enableServiceLinks: false
serviceAccountName: example-workbench
Expand All @@ -96,3 +101,11 @@ spec:
name: workbench-trusted-ca-bundle
optional: true
name: trusted-ca
- name: oauth-config
secret:
defaultMode: 420
secretName: test-ssl-oauth-config
- name: tls-certificates
secret:
defaultMode: 420
secretName: example-workbench-tls

0 comments on commit 1459e23

Please sign in to comment.