There is no need to run gather_odf_client script on non-provider setup

[OdedViner]

No description provided.

[yati1998]

@OdedViner did you verify your image in both provider and non-provider clusters?

[OdedViner]

@OdedViner did you verify your image in both provider and non-provider clusters?

podman build -t quay.io/oviner/ocs-must-gather:provider_mode_1 -f Dockerfile .
podman push quay.io/oviner/ocs-must-gather:provider_mode_1


Running on provider cluster:
$ oc adm must-gather --image=quay.io/oviner/ocs-must-gather:provider_mode_1 > provider_cluster.log
$ cat provider_cluster.log | grep "it is provider"
[must-gather-zvrqm] POD 2024-09-19T08:44:47.880752513Z it is provider cluster


Running on "regular cluster":
$ oc adm must-gather --image=quay.io/oviner/ocs-must-gather:provider_mode_1 > non_provider_cluster.log
$ cat non_provider_cluster.log | grep "it is not"
[must-gather-xj2dw] POD 2024-09-19T09:02:59.573594086Z it is not provider cluster

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OdedViner, yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yati1998]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[black-dragon74]

/hold

[black-dragon74]

What if the current cluster is a consumer (client)? Is that accounted for as well?

[yati1998]

What if the current cluster is a consumer? Is that accounted for as well?

if I am not wrong yes, by provider he means: provider-consumer cluster.
cc @OdedViner

[jilju]

Storagecluster CRD won't be present in client cluster on a provider-client(provider mode) setup.

[yati1998]

@OdedViner please re-verify the check and paste the logs collected.
According to the check you mentioned, odf_client script will not run even if it is a client cluster.

[black-dragon74]

Please do all the custom checks in sub gather scripts. The gather script is an entrypoint and should not contain extraneous checks. I would move it to gather_odf_client

Also, do we need this change @yati1998 ?

[yati1998]

Please do all the custom checks in sub gather scripts. The gather script is an entrypoint and should not contain extraneous checks. I would move it to gather_odf_client

Also, do we need this change @yati1998 ?

No we dont,
Once @OdedViner verify his again, we can close this PR

[openshift-ci]

New changes are detected. LGTM label has been removed.

[black-dragon74]

Closing this as it is not needed.