Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix url typo in runbook for MDS alert #2939

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix url typo in runbook for MDS alert #2939

merged 1 commit into from
Jan 8, 2025

Conversation

rchikatw
Copy link
Contributor

@rchikatw rchikatw commented Jan 3, 2025 •
edited
Loading

@rchikatw
Fix url typo in MDS alert
becb130 
Signed-off-by: rchikatw <rchikatw@redhat.com>
@rchikatw rchikatw changed the title Fix url typo in MDS alert Fix url typo in runbook for MDS alert Jan 7, 2025
weirdwiz
weirdwiz approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@weirdwiz weirdwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, the links work

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

@weirdwiz: changing LGTM is restricted to collaborators

In response to this:

Changes look good to me, the links work

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@weirdwiz
Copy link
Contributor

weirdwiz commented Jan 7, 2025 •
edited
Loading

pinging @umangachapagain for tagging

aruniiird
aruniiird approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@aruniiird aruniiird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rchikatw , changes looks good.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

@aruniiird: changing LGTM is restricted to collaborators

In response to this:

Thanks @rchikatw , changes looks good.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

umangachapagain
umangachapagain reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aruniiird, rchikatw, umangachapagain, weirdwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8561dee into red-hat-storage:main Jan 8, 2025
11 checks passed
@rchikatw
Copy link
Contributor Author

rchikatw commented Jan 8, 2025

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@rchikatw: new pull request created: #2954

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangachapagain umangachapagain umangachapagain left review comments

@weirdwiz weirdwiz weirdwiz approved these changes

@aruniiird aruniiird aruniiird approved these changes

Assignees

@umangachapagain umangachapagain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rchikatw @weirdwiz @openshift-cherrypick-robot @aruniiird @umangachapagain