Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-1012:[release-4.18] filesystem: correct the pool name in the ux backend handler #2928

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2924

/assign parth-gr

In the expandstorage handler pool name is incorrect,

Rook adds the filesystemName prefix to every datapool,
which was missing in the storageclass parameter
https://github.com/rook/rook/blob/44e96c8ab67a27121354a04b121b7f16b6a38894/pkg/operator/ceph/file/filesystem.go#L321

Signed-off-by: parth-gr <paarora@redhat.com>
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: parth-gr.

Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #2924

/assign parth-gr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@parth-gr
Copy link
Member

parth-gr commented Dec 6, 2024

/assign @malayparida2000 @iamniting

@parth-gr
Copy link
Member

parth-gr commented Dec 6, 2024

/jira refresh

@openshift-ci-robot
Copy link

@parth-gr: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@parth-gr
Copy link
Member

parth-gr commented Dec 6, 2024

@openshift-ci openshift-ci bot changed the title [release-4.18] filesystem: correct the pool name in the ux backend handler DFBUGS-1012: [[release-4.18] filesystem: correct the pool name in the ux backend handler](https://github.com/red-hat-storage/ocs-operator/pull/2928#top) Dec 6, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2024

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-1012](https://issues.redhat.com//browse/DFBUGS-1012), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #2924

/assign parth-gr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@parth-gr
Copy link
Member

parth-gr commented Dec 6, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Dec 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2024

@parth-gr: This pull request references [Jira Issue DFBUGS-1012](https://issues.redhat.com//browse/DFBUGS-1012), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Dec 6, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@parth-gr
Copy link
Member

parth-gr commented Dec 6, 2024

/retitle [DFBUGS-1012]: [[release-4.18] filesystem: correct the pool name in the ux backend handler]

@openshift-ci openshift-ci bot changed the title DFBUGS-1012: [[release-4.18] filesystem: correct the pool name in the ux backend handler](https://github.com/red-hat-storage/ocs-operator/pull/2928#top) [DFBUGS-1012]: [[release-4.18] filesystem: correct the pool name in the ux backend handler] Dec 6, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid jira ticket of any type label Dec 6, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #2924

/assign parth-gr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Dec 6, 2024
@parth-gr
Copy link
Member

parth-gr commented Dec 6, 2024

/retitle DFBUGS-1012: [[release-4.18] filesystem: correct the pool name in the ux backend handler]

@openshift-ci openshift-ci bot changed the title [DFBUGS-1012]: [[release-4.18] filesystem: correct the pool name in the ux backend handler] DFBUGS-1012: [[release-4.18] filesystem: correct the pool name in the ux backend handler] Dec 6, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Dec 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2024

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-1012](https://issues.redhat.com//browse/DFBUGS-1012), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

This is an automated cherry-pick of #2924

/assign parth-gr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@iamniting iamniting changed the title DFBUGS-1012: [[release-4.18] filesystem: correct the pool name in the ux backend handler] DFBUGS-1012: [release-4.18] filesystem: correct the pool name in the ux backend handler Dec 6, 2024
@iamniting iamniting changed the title DFBUGS-1012: [release-4.18] filesystem: correct the pool name in the ux backend handler DFBUGS-1012:[release-4.18] filesystem: correct the pool name in the ux backend handler Dec 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8d650e6 into red-hat-storage:release-4.18 Dec 6, 2024
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2024

@openshift-cherrypick-robot: [Jira Issue DFBUGS-1012](https://issues.redhat.com//browse/DFBUGS-1012): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1012](https://issues.redhat.com//browse/DFBUGS-1012) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2924

/assign parth-gr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants