-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #519
base: develop
Are you sure you want to change the base?
Update README.md #519
Conversation
@kilograham A few proposed changes to the readme: - Remove some early access copy - Call out which examples are RP235x only - Fix link the HSTX example Could you review the first paragraph of build instructions too?
@will-v-pi Would this PR be a good opportunity to change the RISC-V compiler link, as you suggested in #516 (comment) ? |
Might want to double check with @Wren6991 about that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a documentation/copy perspective, with one suggestion. Can we merge this in?
Apparently this has conflicts with the current README.md 👇 |
Co-authored-by: nate contino <ncontino@u.rochester.edu>
Everything below this section is from the stock pico-examples, so ignore URLs etc., but generally instructions are the same. | ||
|
||
The Pico SDK default continues to be to build for RP2040 (PICO_PLATFORM=rp2040), so to build for RP2350, you need to pass | ||
By default, the Pico SDK targets builds for RP2040 (PICO_PLATFORM=rp2040). To build for RP2350 instead, pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth mentioning that you can also use e.g. -DPICO_BOARD=pico2
or -DPICO_BOARD=pico2_w
and that will "automagically" select RP2350 for you?
@kilograham A few proposed changes to the readme:
Could you review the first paragraph of build instructions too?