Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #519

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

chrisboross
Copy link

@kilograham A few proposed changes to the readme:

  • Remove some early access copy
  • Call out which examples are RP235x only
  • Fix link the HSTX example

Could you review the first paragraph of build instructions too?

@kilograham A few proposed changes to the readme:
- Remove some early access copy
- Call out which examples are RP235x only
- Fix link the HSTX example

Could you review the first paragraph of build instructions too?
@lurch
Copy link
Contributor

lurch commented Aug 18, 2024

@will-v-pi Would this PR be a good opportunity to change the RISC-V compiler link, as you suggested in #516 (comment) ?

@will-v-pi
Copy link
Contributor

@will-v-pi Would this PR be a good opportunity to change the RISC-V compiler link, as you suggested in #516 (comment) ?

Might want to double check with @Wren6991 about that?

Copy link
Contributor

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a documentation/copy perspective, with one suggestion. Can we merge this in?

README.md Outdated Show resolved Hide resolved
@lurch
Copy link
Contributor

lurch commented Dec 5, 2024

Apparently this has conflicts with the current README.md 👇

kilograham and others added 2 commits December 5, 2024 09:36
Co-authored-by: nate contino <ncontino@u.rochester.edu>
kilograham
kilograham previously approved these changes Dec 5, 2024
@kilograham kilograham changed the base branch from master to develop December 5, 2024 15:38
@kilograham kilograham dismissed their stale review December 5, 2024 15:38

The base branch was changed.

Everything below this section is from the stock pico-examples, so ignore URLs etc., but generally instructions are the same.

The Pico SDK default continues to be to build for RP2040 (PICO_PLATFORM=rp2040), so to build for RP2350, you need to pass
By default, the Pico SDK targets builds for RP2040 (PICO_PLATFORM=rp2040). To build for RP2350 instead, pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth mentioning that you can also use e.g. -DPICO_BOARD=pico2 or -DPICO_BOARD=pico2_w and that will "automagically" select RP2350 for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants