Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add check updates command #577

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: add check updates command #577

wants to merge 4 commits into from
+152 −7

Conversation

alexng353
Copy link
Contributor

No description provided.

@brody192 brody192 changed the title feat: add check updates command feat: add check updates command [WIP] Dec 2, 2024
@alexng353 alexng353 changed the title feat: add check updates command [WIP] feat: add check updates command Dec 4, 2024
@coffee-cup coffee-cup added the release/minor Author minor release label Dec 9, 2024
coffee-cup
coffee-cup reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and just a few comments.

Can you also please add descriptions to any PRs so it makes it easier to review. This should include things like

  • Added commands (screenshots of the output is very useful)
  • Changes to behaviour.

src/commands/check_updates.rs Show resolved Hide resolved
src/commands/check_updates.rs Outdated Show resolved Hide resolved
src/macros.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
src/commands/check_updates.rs Show resolved Hide resolved
@alexng353
review: added return value to check_updates
bf9d609 
simplified check_updates command

fix: more user-friendly error message for check_updates on Config write
failure
@alexng353
refactor: check updates macro -> function
ff13a84
coffee-cup
coffee-cup reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to get this merged soon! Just a small merge conflict and a few linting rules but then I think it would be good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffee-cup coffee-cup coffee-cup left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release/minor Author minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexng353 @coffee-cup