Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example CLI #82

Closed
wants to merge 8 commits into from
Closed

Add example CLI #82

wants to merge 8 commits into from

Conversation

sarthakpati
Copy link
Contributor

@sarthakpati sarthakpati commented Sep 2, 2020

Following conversation with Pallavi, I have added a basic command line interface to get collage features. Items that need to be populated are commented with todo.

@nathanhillyer
Copy link
Contributor

Looks good so far!

@nathanhillyer
Copy link
Contributor

One suggestion– could you put all the files into a cli subfolder, please?

@sarthakpati
Copy link
Contributor Author

One suggestion– could you put all the files into a cli subfolder, please?

Done. Looking forward to when this is fully functional and ready. 😄

@sarthakpati
Copy link
Contributor Author

BTW, I was not sure what other input parameters are required for collage (for example, the radius and binning), so those could also part of the CLI.

@nathanhillyer
Copy link
Contributor

@sarthakpati What are you expecting in the output CSV file, and what format would be best for CaPTk to process the features? Would you like our CLI tool to write out image files?

@sarthakpati
Copy link
Contributor Author

sarthakpati commented Sep 15, 2020

Hi @nathanhillyer,

  1. Output CSV can be in the following format (no need to write the parameters used, I will do that when I parser the output from CaPTk):
FeatureName,Value
  1. From CaPTk's layer, there is no need to write images. However, if you want to write images, put it up as a parameter that can be controlled (and is preferably disabled by default).

@nathanhillyer
Copy link
Contributor

@sarthakpati Thanks for the feedback, and starter project. We're going to use #87 as the final pull request. Feel free to try it out via pip install collageradiomicscli.

@sarthakpati sarthakpati deleted the add_cli branch September 21, 2020 10:58
@sarthakpati
Copy link
Contributor Author

sarthakpati commented Sep 21, 2020

Hi @nathanhillyer, would it be possible for you to merge my commites into your PR? I want my contribution to be recognized in this effort.

@nathanhillyer
Copy link
Contributor

Yes, sure!

@sarthakpati
Copy link
Contributor Author

Hi @nathanhillyer, I have merged your cli branch with mine and this is now up-to-date: https://github.com/sarthakpati/collageradiomics/tree/add_cli

If you don't mind merging this, it would be great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish out CLI stub Integrate CLI with our data input into our existing core docker image.
2 participants