Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit install and landing pages #3722

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

dwelsch-esi
Copy link
Contributor

Proofread and edit all install pages and landing page.

Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>
Update install instructions, including quick start.

Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>

* 64-bit Intel x86-compatible processor
* Python 3.83.12
* Python 3.83.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change this to Python 3.10. I know earlier, it was Python 3.8-3.12 but we have tested using Python 3.10 only.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was one of the comments for me, but since you are modifying this, would be great if you could take of this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment on lines 142 to 148
[-1.6091, 1.0449, 1.7788, ..., -0.9904, 1.0861, 2.2431],
[-1.5307, 0.8442, 1.5157, ..., -0.7793, 0.6327, 2.3861],
...,
[-1.3610, 1.4499, 2.2068, ..., -0.8188, 1.1155, 2.5962],
[-1.1619, 1.2217, 2.1050, ..., -0.5301, 0.9150, 2.1458],
[-1.6340, 0.9826, 2.2459, ..., -1.0769, 0.9054, 2.2315]],
device='cuda:0', grad_fn=<AliasBackward0>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tensor values were initially aligned. It seems an extra space has been added. Could you please revert this change?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

# Set the release tag, for example "|version|"
export release_tag="<version release tag>"
# Set the wheel file name with extension,
# for example "aimet_torch-|version|\+cu121-cp310-cp310-manylinux_2_34_x86_64.whl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have erased my changes from my recent PR: dwelsch-esi@2ab3c16

for example "aimet_torch-|version|+cu121\ |torch_whl_suffix|"

.. |torch_whl_suffix| replace:: -cp310-none-any.whl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure changes from my recent commit are applied correctly. 2ab3c16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor

@quic-hitameht quic-hitameht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the requested changes.

Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>

* 64-bit Intel x86-compatible processor
* Python 3.8–3.12
* Python 3.8 – 3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change from Python 3.8 - 3.10 to only Python 3.10?

@quic-hitameht quic-hitameht merged commit 545f33b into quic:develop Jan 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants