-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit install and landing pages #3722
Conversation
Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>
Update install instructions, including quick start. Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>
Docs/install/quick-start.rst
Outdated
|
||
* 64-bit Intel x86-compatible processor | ||
* Python 3.8–3.12 | ||
* Python 3.8 – 3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change this to Python 3.10. I know earlier, it was Python 3.8-3.12 but we have tested using Python 3.10 only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was one of the comments for me, but since you are modifying this, would be great if you could take of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Docs/install/quick-start.rst
Outdated
[-1.6091, 1.0449, 1.7788, ..., -0.9904, 1.0861, 2.2431], | ||
[-1.5307, 0.8442, 1.5157, ..., -0.7793, 0.6327, 2.3861], | ||
..., | ||
[-1.3610, 1.4499, 2.2068, ..., -0.8188, 1.1155, 2.5962], | ||
[-1.1619, 1.2217, 2.1050, ..., -0.5301, 0.9150, 2.1458], | ||
[-1.6340, 0.9826, 2.2459, ..., -1.0769, 0.9054, 2.2315]], | ||
device='cuda:0', grad_fn=<AliasBackward0>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Docs/install/install_host.rst
Outdated
# Set the release tag, for example "|version|" | ||
export release_tag="<version release tag>" | ||
# Set the wheel file name with extension, | ||
# for example "aimet_torch-|version|\+cu121-cp310-cp310-manylinux_2_34_x86_64.whl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have erased my changes from my recent PR: dwelsch-esi@2ab3c16
for example "aimet_torch-|version|+cu121\ |torch_whl_suffix|"
.. |torch_whl_suffix| replace:: -cp310-none-any.whl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure changes from my recent commit are applied correctly. 2ab3c16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the requested changes.
Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>
|
||
* 64-bit Intel x86-compatible processor | ||
* Python 3.8–3.12 | ||
* Python 3.8 – 3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change from Python 3.8 - 3.10 to only Python 3.10?
Proofread and edit all install pages and landing page.