Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in patch_attr when an attribute doesn't exist #2778

Merged
merged 1 commit into from
Feb 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def patch_attr(obj, attr_name, new_attr)-> _ContextManager:
if attr_name in obj._parameters or attr_name in obj._buffers: # pylint: disable=protected-access
return _patch_param_or_buffer(obj, attr_name, new_attr)

old_attr = getattr(obj, attr_name)
old_attr = getattr(obj, attr_name, None)
action = lambda: setattr(obj, attr_name, new_attr)

def cleanup():
Expand All @@ -127,7 +127,7 @@ def cleanup():
except AttributeError:
pass

if not hasattr(obj, attr_name):
if not hasattr(obj, attr_name) and old_attr is not None:
setattr(obj, attr_name, old_attr)

return _ContextManager(action, cleanup)
Expand Down
Loading