Custom Op CMake Fix #2598
Merged
Custom Op CMake Fix #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashvin Kumar <quic_ashvkuma@quicinc.com>
…sion Signed-off-by: Ashvin Kumar <quic_ashvkuma@quicinc.com>
|
Did you merge this @quic-ashvkuma ? |
Unless I am mistaken this looks like the PR was closed without merging? |
|
I closed this without merging because it looked like some additional changes were needed. I'm going to reopen now because Bharath and Evgeny have re-evaluated and it looks like we will be moving ahead with this fix. |
quic-akhobare
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added -DENABLE_TESTS option to CMake
Signed-off-by: Ashvin Kumar quic_ashvkuma@quicinc.com