Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable graphql-client quickstart tests for now #1486

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Jan 7, 2025

Disable graphql-client quickstart tests for now

Blocked by quarkusio/quarkus#45334

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

@rsvoboda rsvoboda requested a review from jmartisk January 7, 2025 08:37
@rsvoboda rsvoboda changed the title Disable graphql-client quickstart Disable graphql-client quickstart for now Jan 7, 2025
@jmartisk
Copy link
Contributor

jmartisk commented Jan 7, 2025

Wouldn't just disabling the quickstart's test be a less brutal solution? :)

@rsvoboda
Copy link
Member Author

rsvoboda commented Jan 7, 2025

Ok, I can do that :)

@rsvoboda rsvoboda force-pushed the disable.graphql-client.qs branch from 6968560 to eaef7a1 Compare January 7, 2025 08:59
@rsvoboda rsvoboda changed the title Disable graphql-client quickstart for now Disable graphql-client quickstart tests for now Jan 7, 2025
@rsvoboda
Copy link
Member Author

rsvoboda commented Jan 7, 2025

@jmartisk updated

@rsvoboda rsvoboda force-pushed the disable.graphql-client.qs branch from eaef7a1 to d846cea Compare January 7, 2025 09:05
@rsvoboda
Copy link
Member Author

rsvoboda commented Jan 7, 2025

I needed to put @Disabled on GraphQLClientIT too

@gsmet
Copy link
Member

gsmet commented Jan 7, 2025

We don't need this PR right as you found an alternative?

@jmartisk
Copy link
Contributor

jmartisk commented Jan 7, 2025

Not sure what you mean, we haven't implemented any alternative approach yet

@rsvoboda
Copy link
Member Author

rsvoboda commented Jan 7, 2025

Alternative was possible for vertx-quickstart but graphql-client-quickstart is blocked by the fact that https://swapi-graphql.netlify.app uses https://swapi.dev/ server in the background

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@rsvoboda rsvoboda force-pushed the disable.graphql-client.qs branch from d846cea to 971fa44 Compare January 8, 2025 09:49
@rsvoboda
Copy link
Member Author

rsvoboda commented Jan 8, 2025

Rebased to get #1484 fix for failing vertx-quickstart

Copy link

quarkus-bot bot commented Jan 8, 2025

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 971fa44.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@rsvoboda
Copy link
Member Author

rsvoboda commented Jan 8, 2025

@jmartisk all green now ;)

@jmartisk jmartisk merged commit 13f5612 into quarkusio:development Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants