-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove operation id prefix #873
Merged
ricardozanini
merged 8 commits into
quarkiverse:main
from
yuhaibohotmail:remove-operation-id-prefix
Nov 29, 2024
Merged
remove operation id prefix #873
ricardozanini
merged 8 commits into
quarkiverse:main
from
yuhaibohotmail:remove-operation-id-prefix
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ricardozanini @ricardozanini |
ricardozanini
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an unusual use case; many thanks for bringing this to our attention and sending the PR.
Now, with the test, it makes much more sense.
hbelmiro
requested changes
Nov 28, 2024
...d-prefix/src/test/java/io/quarkiverse/openapi/generator/it/RemoveOperatiionIdPrefixTest.java
Outdated
Show resolved
Hide resolved
...d-prefix/src/test/java/io/quarkiverse/openapi/generator/it/RemoveOperatiionIdPrefixTest.java
Outdated
Show resolved
Hide resolved
…va/io/quarkiverse/openapi/generator/it/RemoveOperatiionIdPrefixTest.java Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
…va/io/quarkiverse/openapi/generator/it/RemoveOperatiionIdPrefixTest.java Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
hbelmiro
approved these changes
Nov 28, 2024
hbelmiro
approved these changes
Nov 28, 2024
7 tasks
hbelmiro
pushed a commit
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[0.9.x] Subject
Fix #866
When use smallrye openapi operationid strategy CLASS_METHOD,operationId fields take the form of "class_name_method". For example, "User_findAll". We want remove operationId prefix (e.g. User_findAll=> findAll)
In this PR, we add a config properties remove-operation-id-prefix,to delete class name from operationId. The properties are passed to the openapi-generator, and the specific functions are executed by the openapi-generator.
https://github.com/OpenAPITools/openapi-generator/blob/4c5a57fe7bae59483bb8fa9218be8dc4f82e1bda/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java#L5638