Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show comments for NGS and ProteomicsMeasurements #962

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

Steffengreiner
Copy link
Contributor

What was changed
Currently the Proteomics and Ngs Measurements don't show the provided comments during measurement registration. This error appears for pooled and unpooled measurements.

This PR aims to provide the comments for singular Samples within the measurement overview, while providing the possiblity to open the information dialog for pooled samples

@Steffengreiner Steffengreiner requested a review from a team as a code owner December 20, 2024 13:43
@Steffengreiner Steffengreiner self-assigned this Jan 7, 2025
@KochTobi KochTobi self-assigned this Jan 7, 2025
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sven1103
Copy link
Contributor

sven1103 commented Jan 8, 2025

@Steffengreiner what is the related issue? Please always link the corresponding issue in the PR via GitHub's x-ref feature:
image

Copy link
Contributor

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing x-ref to an issue.

@Steffengreiner
Copy link
Contributor Author

Heya @sven1103, Thanks for the Feedback. I linked the issue in question 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proteomics Measurements don't return the information provided in the comment column
3 participants