This repository has been archived by the owner on Nov 2, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 8
native except handler API #21
Open
maxfischer2781
wants to merge
17
commits into
python-trio:master
Choose a base branch
from
maxfischer2781:native_except_handler
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
native except handler API #21
maxfischer2781
wants to merge
17
commits into
python-trio:master
from
maxfischer2781:native_except_handler
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxfischer2781
changed the title
draft for native except handler API
[WIP] native except handler API
Jun 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 66.55% 69.88% +3.32%
==========================================
Files 11 12 +1
Lines 311 425 +114
Branches 28 49 +21
==========================================
+ Hits 207 297 +90
- Misses 101 115 +14
- Partials 3 13 +10
|
As a first draft, this is basically done. Let me know if there is anything else that I should add, or something that needs clarification or discussing. |
maxfischer2781
changed the title
[WIP] native except handler API
native except handler API
Nov 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a prototype implementation of #20. Notable additions and changes include:
ExceptionGroup
is "Generic" and can be specialised by exceptions. This allows catching specific groups, e.g.except ExceptionGroup[KeyError, TypeError] as exc_group:
.ExceptionGroup[A, B, C]
andissubclass(exc_group, ExceptionGroup[ABC])
.ExceptionGroup
attributes.exceptions
and.sources
are tuples instead of lists. This is intended to prevent inconsistencies between the type and its attributes.This PR does not change:
ExceptionGroup
having.message
,.exceptions
and.sources
attributes.except ExceptionGroup:
catching all possibleExceptionGroup
s.