Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: linters #248

Merged
merged 12 commits into from
Nov 20, 2024
Merged

feat: linters #248

merged 12 commits into from
Nov 20, 2024

Conversation

m30m
Copy link
Collaborator

@m30m m30m commented Nov 20, 2024

No description provided.

Copy link
Contributor

@danimhr danimhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge with main and add it to precommit too?

registry-url: "https://registry.npmjs.org"

- name: Install dependencies
run: npm install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should'nt we use npm ci?

working-directory: contracts/evm
run: npm install
- name: Install npm dependencies
run: npm install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe npm ci?

@m30m m30m merged commit 7ac2cf2 into main Nov 20, 2024
1 check passed
@m30m m30m deleted the feat/linters branch November 20, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants