feat: claim rewards #552
Merged
feat: claim rewards #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
+1254
to
+1266
| let publisher_exposure = { | ||
| let mut publisher_exposure = 0; | ||
| for i in 0..positions.get_position_capacity() { | ||
| if let Some(position) = positions.read_position(i).unwrap() { | ||
| if (position.target_with_parameters | ||
| == TargetWithParameters::IntegrityPool { | ||
| publisher: *publisher, | ||
| }) | ||
| { | ||
| publisher_exposure += position.amount; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
this can cause issues if someone unstake but don't claim rewards
There was a problem hiding this comment.
they can't clean up their positions until they claim everything
keyvankhademi
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing parallelism created a bunch of issues with running the code in debug mode (stack overflow, segfault) so now we need
cargo run --release. I haven't been able to solve this.