Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios13): Fixing issue with changes to ASWebAuthenticationSession. #15

Merged
merged 2 commits into from
Oct 16, 2019
Merged

fix(ios13): Fixing issue with changes to ASWebAuthenticationSession. #15

merged 2 commits into from
Oct 16, 2019

Conversation

ebsi-cgoboncan
Copy link
Contributor

PR Checklist

What is the current behavior?

Browser crashes on iOS 13 when openAuth is used.

What is the new behavior?

Browser does not crash on iOS 13 when openAuth is used.

Fixes/Implements/Closes #14.

Note

I had to add types/ios.d.ts to get Typescript to recognize the new APIs. You'll probably want to remove it once tns-platform-declarations is updated.

@jdnichollsc jdnichollsc merged commit 57d7eb1 into proyecto26:master Oct 16, 2019
@jdnichollsc
Copy link
Member

Woww thanks mate! Let me publish the new version :)

@jalbatross
Copy link

Nice work!!

@ebsi-cgoboncan
Copy link
Contributor Author

Hi @jdnichollsc could we get a new release of the plugin?

@jdnichollsc
Copy link
Member

Ohh I identified another bug from iOS 13, I'm going to publish that for tomorrow 😅

@ebsi-cgoboncan
Copy link
Contributor Author

Okay cool. Let me know if there's anything else I can help with.

@ebsi-cgoboncan
Copy link
Contributor Author

Any updates on publishing a release?

@jdnichollsc
Copy link
Member

Sorry guys, let me publish tomorrow in the morning, there's some issues with the modal transitions like partialCurl with iOS, so I'm going to add that fix and publish the new version, let me confirm you 😅

@jdnichollsc
Copy link
Member

jdnichollsc commented Nov 14, 2019

ok guys, about the other issue with the transitions (partialCurl, etc), it's an issue from iOS 13 => https://forums.developer.apple.com/thread/124765
Right now I have another issue with a missing method from iOS runtime => NativeScript/ios-jsc#1228

@jdnichollsc
Copy link
Member

Done! Check the last version 2.1.0, thanks for your help guys! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openAuth does not work for iOS13
3 participants