Update the dependencies #27
Conversation
celian-garcia
force-pushed
the
update_dependencies
branch
2 times, most recently
from
9027cce to
c9e0ffb
Compare
Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>
celian-garcia
force-pushed
the
update_dependencies
branch
from
c9e0ffb to
71e5ff4
Compare
| @@ -43,6 +43,7 @@ cd examples/<example-folder> | |||
| npm install | |||
| npm link monaco-promql | |||
| npm start | |||
| # Then modify manually the monaco-promql import :/ "monaco-promql" -> "monaco-promql/lib" | |||
There was a problem hiding this comment.
that would be great actually to take some time to implement the issue #10. It would simplify a lot this process.
And this is something already done in codemirror-promql. So we can just (almost) copy and past what is there.
There was a problem hiding this comment.
Checking the repo I'm still not sure how you make npm link work, is it using build.sh and then cd lib && npm link ?
Moreover it seems that you are using a slightly outdated version of your project in your example normal ? 0.11.0 instead of 0.12.0
There was a problem hiding this comment.
oh no for the development I'm using a vanilla that doesn't require /depend of any TS framework.
It's in the /app folder actually. So no need of creating a link a so on.
There was a problem hiding this comment.
ah ... in that particular case I wanted to make sure that my examples was always working :/ so I need to npm link it because it is not released. And I think that even if I create a vanilla example which don't need npm link, I'll still want to make this check everytime on other examples.
I will try what I said, if at least I can get rid of the final ugly manual step, it's acceptable to me.
There was a problem hiding this comment.
well also you can said, since you are independ of a TS framework, then for sure it will work with Angular or with React.
Integration can be a bit tricky for some cases for sure, but as long as you don't depend of any lib from Angular / React and so you don't depend on a TS framework, then integration is defacto possible.
That's why you are creating a lib, and you won't test every possible framework. It's a good things to show how to integrate it. But your lib shouldn't be driven by how Angular is working. That's why it's a bit better to have a vanilla app instead to ease the development of the lib.
There was a problem hiding this comment.
I spent so much time to make it work with Angular that I just wanted to provide more support than "hey look the config is that, by the way it is a nightmare to integrate, wish you all the best !"
Generally speaking I agree with you though. For example, react example was much easier and would be okay to even be removed or not as maintained as Angular example.
No description provided.