fix(dynamodb): remove deprecated function #2888
Open
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaaron
previously approved these changes
Jan 17, 2025
The fact that here: #2853 users are getting 404 made me think that maybe this deprecated custom resolver func causes it? I'm not sure though, just a shot in the dark.
|
Signed-off-by: Petu Eusebiu <petu.eusebiu@gmail.com>
eusebiu-constantin-petu-dbk
force-pushed
the
dynamodb_rm_deprecated
branch
from
969bd16 to
1fc8532
Compare
|
Hello @huynguyen-anduin, can you try this patch? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2888 +/- ##
==========================================
- Coverage 91.89% 91.88% -0.02%
==========================================
Files 170 170
Lines 30291 30290 -1
==========================================
- Hits 27836 27832 -4
- Misses 1827 1828 +1
- Partials 628 630 +2 ☔ View full report in Codecov by Sentry. |
andaaron
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.