fix(sync): added bearer client for sync #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2222 +/- ##
==========================================
- Coverage 92.89% 92.79% -0.10%
==========================================
Files 165 166 +1
Lines 21582 21760 +178
==========================================
+ Hits 20048 20192 +144
- Misses 956 980 +24
- Partials 578 588 +10 ☔ View full report in Codecov by Sentry. |
rchincha
reviewed
Feb 1, 2024
eusebiu-constantin-petu-dbk
force-pushed
the
fix_sync_issues
branch
2 times, most recently
from
94f6d12 to
11a34e5
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
fix_sync_issues
branch
2 times, most recently
from
ba08f4d to
24f9536
Compare
andaaron
reviewed
Feb 5, 2024
eusebiu-constantin-petu-dbk
force-pushed
the
fix_sync_issues
branch
8 times, most recently
from
9d8e00d to
a16ecab
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
fix_sync_issues
branch
from
a16ecab to
61bcdfd
Compare
andaaron
reviewed
Feb 9, 2024
eusebiu-constantin-petu-dbk
force-pushed
the
fix_sync_issues
branch
from
61bcdfd to
fa27ac8
Compare
fixed ping function taking too much time closes: project-zot#2213 project-zot#2212 Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
eusebiu-constantin-petu-dbk
force-pushed
the
fix_sync_issues
branch
from
fa27ac8 to
f4352b9
Compare
andaaron
approved these changes
Feb 12, 2024
|
This should solve two of your issues, one is periodically sync now should work with your azure instance. Can you test it on your side please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed ping function taking too much time
closes: #2213 #2212
What type of PR is this?
bug
Which issue does this PR fix:
Fixes the sync taking too much time to fallback to serving local cached image, in case the remote is unavailable.
Added bearer auth for http client.
Should also fix multiple unauthorized messages we saw in sync logs when trying to sync referrers.
This is WIP
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.