Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add info about helm value deployment strategy type. #158

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

ericgraf
Copy link
Contributor

@ericgraf ericgraf commented Feb 6, 2024

What type of PR is this?

documentation

Which issue does this PR fix:

Adds info about a new helm value strategy.type.

What does this PR do / Why do we need it:

Adds very basic info about this change project-zot/helm-charts#38 hopefully comming to the helm-charts repo. This PR is dependent on the merge of the PR above.

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: ericgraf <eric@giantswarm.io>
Copy link
Contributor

@mbshields mbshields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
As a nice-to-have, we could add this field in the command output examples in Step 2 and Step 3.

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

for v2.0.2 docs

@rchincha rchincha merged commit 1df065d into project-zot:main Feb 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants