Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Call button crash and Gradle build fail #69

Closed
wants to merge 2 commits into from
Closed

Fixed Call button crash and Gradle build fail #69

wants to merge 2 commits into from

Conversation

Niranjan-B
Copy link
Member

  1. The ripple effect library used has an open issue (Underflow in restore - more restores than saves : on Android M (6.0) traex/RippleEffect#76). Used this (https://github.com/patrickpissurno/RippleEffect/) library to work around the problem having the same API.
  2. The build was failing on Android Studio 3.1 due to differences in version numbers. The support library version number used was 27.1.1 but 'com.github.rey5137:material:1.2.1' was using 'com.android.support:cardview-v7:22.2.0 ' which created the conflict.
  3. Resolved "Failed to resolve: common [duplicate]" (on Android Studio 3.1) by re-positioning the maven and google repository URL's in top level build.gradle file. FYI -> (https://stackoverflow.com/questions/50565776/build-gradle-error-failed-to-resolve-common?noredirect=1&lq=1)

@Swati4star
Copy link
Member

The changes are good.
Just squash the commits into a single one.

@Niranjan-B Niranjan-B closed this Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants