Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Gitium Heroku/Dokku friendly #162

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jlcastillo
Copy link

@jlcastillo jlcastillo commented Mar 30, 2018

First of all, thanks for sharing this excellent plugin.

The reason for this PR is that Gitium, as it is now, is not Heroku/Dokku friendly for the following reasons:

  1. It assumes that only wp-contents should be versioned. However herokuish platforms rely on all the code of an app being available at the time you push. In addition, there is no clear advantage on having wp-core separated from wp-contents.

  2. It assumes that the remote repo URL won't be available until someone visits the admin panel and writes it down. In a herokuish platform, the remote repo would be defined in a linked database or an environment variable.

  3. It doesn't automatically initialize and connect to the remote repository, relying on a person to visit the admin page and following the step-by-step setup procedure. In herokuish platforms, you would expect your app to be fully working after doing "git push".

  4. It automatically regenerates the SSH keys and webhooks when you manually disconnect from the repo. This is not strictly a problem with herokuish platforms, but looks unnecessary and a bit annoying.

@DenisFlorin
Copy link
Contributor

Hi, @jlcastillo!

I hope you are well. My apologies for not responding to your PR.

Please let me know if you are still using Gitium on your platform and if it still interests you. Considering the PR has been open for a while and the plugin has undergone many changes, there seems to be a conflict. I was wondering if it was possible to rebase and push the new changes?

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants