Skip to content
This repository has been archived by the owner on Jun 2, 2019. It is now read-only.

xcode project dependencies #25

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

xcode project dependencies #25

wants to merge 7 commits into from

Conversation

ratzlaff
Copy link

@ratzlaff ratzlaff commented May 12, 2016

create xcscheme files for each project.
fix 'dependson' for xcode generator
Should resolve #13

tr = nil
end

function suite.setup()
_ACTION = "xcode4"
xcode.used_ids = { } -- reset the list of generated IDs

wks, prj = test.createWorkspace()
wks, prj1 = test.createWorkspace()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it really your intention to create a second workspace? I would have thought createProject() would be more appropriate here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, I dont know =) I was trying to use the same logic/format as the other tests that were already in place. Certainly dont need multiple workspaces.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search the code for test.createProject() and you'll find usage examples.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Near as I can tell, this is doing the same things as all the other tests...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I usually do:

local wks, prj1 = test.createWorkspace()
local prj2 = test.createproject()

Which puts both projects in the same workspace, instead of in two different workspaces.

Copy link
Author

@ratzlaff ratzlaff May 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please forgive my stubbornness but I don't know where I am creating a second workspace. I only see one 'test.createWorkspace()' inside the suite.setup() funciton. I originally changed the 'prj' to 'prj1' just to have numbers on all the prj variables, but have un-done that change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh, entirely my fault. Please disregard. :p

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! This was a good exercise in understanding the testing logic =)

@starkos
Copy link
Member

starkos commented May 12, 2016

I don't know enough about Xcode schemes to judge the implementation, but this looks pretty good to me. I made a couple of minor suggestions inline.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared Schemes
2 participants