V2 remove deprecation #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second argument to assert_raises is custom error message
Using ArgumentError sounds like a good idea since we received invalid argument to this method, but this exception is suppose to be when you pass the wrong number of arguments or missing keywords.
Error Your bundle only supports platforms ["arm64-darwin-22", "java"] but your local
stoivo
force-pushed
the
v2-remove-deprecation
branch
from
929d3da to
67e0e57
Compare
stoivo
force-pushed
the
v2-remove-deprecation
branch
from
67e0e57 to
935308c
Compare
grosser
approved these changes
May 28, 2024
| @@ -89,7 +94,7 @@ def self.merge(*rule_sets) | |||
| end | |||
| end | |||
|
|
|||
| merged = properties.each_with_object(RuleSet.new(nil, nil)) do |(property, details), rule_set| | |||
| merged = properties.each_with_object(RuleSet.new) do |(property, details), rule_set| | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why and what is being done.
Pre-Merge Checklist