#918 fixing spot DBCron test failure. (#936)

The test itself wasn't quite right. it should sort by asc (false), not descending (true). and ordering by uid (aka entry order) as well.
pradosoft · May 4, 2023 · d5d14da · d5d14da
1 parent 4656912
commit d5d14da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/framework/Util/Cron/TDbCronModule.php b/framework/Util/Cron/TDbCronModule.php
@@ -815,8 +815,8 @@ public function getCronLog($name, $pageSize, $offset, $sortingDesc = null)
 			$sortingDesc ??= true;
 		}
 		if ($sortingDesc !== null) {
-			$sortingDesc = TPropertyValue::ensureBoolean($sortingDesc) ? "DESC" : "ASC";
-			$orderby = " ORDER BY lastExecTime $sortingDesc, processCount $sortingDesc";
+			$sortingDesc = TPropertyValue::ensureBoolean($sortingDesc) ? 'DESC' : 'ASC';
+			$orderby = " ORDER BY lastExecTime $sortingDesc, tabuid $sortingDesc, processCount $sortingDesc";
 		}
 		$cmd = $db->createCommand(
 			"SELECT * FROM {$this->_tableName} WHERE {$where}active IS NULL{$orderby}{$limit}"

diff --git a/tests/unit/Util/Cron/TDbCronModuleTest.php b/tests/unit/Util/Cron/TDbCronModuleTest.php
@@ -240,7 +240,7 @@ public function testLogCronTask()
 
 		self::assertEquals(5, $this->obj->getCronLogCount());
 
-		$log = $this->obj->getCronLog(null, false, false, true);
+		$log = $this->obj->getCronLog(null, false, false, false);
 		self::assertEquals(5, count($log));
 
 		self::assertEquals('testTaskAA', $log[0]['name']);