Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop 2.7 and adopt 3.3 #219

Closed
wants to merge 4 commits into from
Closed

Drop 2.7 and adopt 3.3 #219

wants to merge 4 commits into from

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented Jan 4, 2024

No description provided.

that-jill added a commit that referenced this pull request Jan 4, 2024
@that-jill
Push down nokogiri version
1db5e21 
To maintain compatibility with Ruby versions < 3

see #219
that-jill
that-jill reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@that-jill that-jill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just leaving a reminder here to unpin all the nokogiri versions we've tossed into gemfiles (and generally check to see whether #214 has merged and if we should add stuff here to fix patches there)

@that-jill that-jill mentioned this pull request Jan 4, 2024
Merged
@xjunior xjunior closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@that-jill that-jill that-jill left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xjunior @that-jill