[PLAY-1798] Enable Dark Mode in Loading Inline Text and Labels #4130
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmhorsey
added
milano
kangaree
reviewed
Jan 16, 2025
| <Body color="light"> | ||
| <Body | ||
| color="light" | ||
| dark |
There was a problem hiding this comment.
This is the right thinking! But, with this, it makes it so dark mode colors are applied even in "light" mode.
I would pass the dark prop to <Body />:
type LoadingInlineProps = {
align?: "left" | "center" | "right",
aria?: { [key: string]: string },
className?: string,
data?: { [key: string]: string },
dark?: boolean
htmlOptions?: {[key: string]: string | number | boolean | (() => void)},
id?: string,
text?: string,
}
const {
align = 'left',
aria = {},
className,
data = {},
dark = false,
htmlOptions = {},
id,
text = ' Loading',
} = props
<Body color="light" dark={dark}>
There was a problem hiding this comment.
Of course! Fixing now, thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Dark mode enabled in React Loading Inline kit page, all text and labels are now using $text_dk_light.
Story PLAY-1798
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.