Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Substrate.io Migration] Tutorials -> Build a Parachain -> Acquire a TestNet Slot #28

Merged

Conversation

nhussein11
Copy link
Collaborator

The "Acquire a testnet slot" page was migrated from the existing Substrate.io Tutorial section: https://docs.substrate.io/tutorials/build-a-parachain/acquire-a-testnet-slot/#test-your-parachain

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|89 col 20| [Vale.Terms] Use 'parachains' instead of 'Parachains'.
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|91 col 19| [Vale.Terms] Use 'parachains' instead of 'Parachains'.
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|96 col 23| [Vale.Spelling] Did you really mean 'Prathreads'?
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|96 col 23| [Papermoon.CustomDictionary] Did you really mean 'Prathreads'?
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|262 col 28| [Vale.Terms] Use 'relay chain' instead of 'Relay Chain'.
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|264 col 305| [Google.Spacing] 't.J' should have one space.
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|283 col 10| [Vale.Spelling] Did you really mean 'genesisHead'?
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|283 col 10| [Papermoon.CustomDictionary] Did you really mean 'genesisHead'?
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|284 col 10| [Papermoon.CustomDictionary] Did you really mean 'validationCode'?
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|284 col 10| [Vale.Spelling] Did you really mean 'validationCode'?
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|285 col 10| [Vale.Spelling] Did you really mean 'paraKind'?
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|285 col 10| [Papermoon.CustomDictionary] Did you really mean 'paraKind'?
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|294 col 61| [Vale.Terms] Use 'parachains' instead of 'Parachains'.
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|296 col 29| [Vale.Terms] Use 'parachains' instead of 'Parachains'.
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|304 col 18| [Vale.Terms] Use 'blockchain' instead of 'Blockchain'.
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|306 col 239| [Vale.Terms] Use 'relay chains' instead of 'Relay chains'.
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|322 col 37| [Papermoon.CustomDictionary] Did you really mean 'alice'?
tutorials/polkadot-sdk/build-a-parachain/connect-a-parachain.md|322 col 37| [Vale.Spelling] Did you really mean 'alice'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|6 col 11| [Vale.Terms] Use 'relay chain' instead of 'Relay Chain'.
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|25 col 90| [Vale.Spelling] Did you really mean 'toolchain'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|25 col 90| [Papermoon.CustomDictionary] Did you really mean 'toolchain'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|28 col 18| [Vale.Terms] Use 'relay chain' instead of 'Relay Chain'.
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|67 col 4| [Vale.Terms] Use 'relay chain' instead of 'Relay Chain'.
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|79 col 104| [Papermoon.Acronyms] Spell out 'SCALE', if it's unfamiliar to the audience.
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|84 col 138| [Papermoon.Acronyms] Spell out 'SCALE', if it's unfamiliar to the audience.
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|88 col 301| [Papermoon.CustomDictionary] Did you really mean 'protocolId'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|88 col 301| [Vale.Spelling] Did you really mean 'protocolId'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|93 col 14| [Vale.Terms] Use 'relay chain' instead of 'Relay Chain'.
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|103 col 40| [Papermoon.CustomDictionary] Did you really mean 'alice'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|103 col 40| [Vale.Spelling] Did you really mean 'alice'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|174 col 154| [Papermoon.CustomDictionary] Did you really mean 'alice'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|174 col 154| [Vale.Spelling] Did you really mean 'alice'?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|174 col 154| [Vale.Spelling] Did you really mean 'alice'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|174 col 154| [Papermoon.CustomDictionary] Did you really mean 'alice'?

@nhussein11 nhussein11 requested a review from 0xLucca September 11, 2024 15:29
@nhussein11 nhussein11 added B0 - Needs Review Pull request is ready for review and removed In Progress labels Sep 11, 2024
@eshaben
Copy link
Collaborator

eshaben commented Sep 26, 2024

@dawnkelly09 this is ready for review

@eshaben
Copy link
Collaborator

eshaben commented Sep 26, 2024

Gahhhh just realized I made a bunch of changes to content that is in this branch but being reviewed in another PR 😭

dawnkelly09
dawnkelly09 previously approved these changes Oct 2, 2024
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions. Thank you for working on this!

…t.md

Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
nhussein11 and others added 4 commits October 2, 2024 14:59
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@0xLucca 0xLucca requested review from dawnkelly09 and 0xLucca October 3, 2024 11:44
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhussein11 nhussein11 merged commit 3355278 into master Oct 3, 2024
@nhussein11 nhussein11 deleted the nhussein11/tutorials-substrate-acquire-a-testnet-slot branch October 3, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants