Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Deny repeatedly adding removed mining key #208

Merged
merged 10 commits into from
Jun 21, 2019
Merged

(Fix) Deny repeatedly adding removed mining key #208

merged 10 commits into from
Jun 21, 2019

Conversation

maxaleks
Copy link
Contributor

@varasev varasev self-requested a review June 17, 2019 17:37
varasev
varasev requested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@varasev varasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add miningKey checking using the hasMiningKeyBeenRemoved getter into the VotingToChangeKeys contract at the stage of ballot creation.

contracts/KeysManager.sol Show resolved Hide resolved
varasev
varasev reviewed Jun 18, 2019
View reviewed changes
contracts/KeysManager.sol Outdated Show resolved Hide resolved
varasev
varasev reviewed Jun 19, 2019
View reviewed changes
contracts/KeysManager.sol Outdated Show resolved Hide resolved
@varasev
Copy link
Contributor

varasev commented Jun 20, 2019

The latest changes look fine. Let's also cover the VotingToChangeKeys.createBallot and createBallotToAddNewValidator functions by unit tests in a part of trying to add a new miningKey which was removed before.

@varasev varasev self-requested a review June 21, 2019 11:47
@varasev varasev merged commit ea84f61 into poanetwork:master Jun 21, 2019
@varasev varasev mentioned this pull request Jun 21, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varasev varasev varasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxaleks @varasev