AxisAlignedBB is now immutable

[Dhaiven]

Like #90 but for AABB, fix #88

[dktapps]

I'd prefer if we kept the *Copy versions. That way, only the people using the mutable functions will get their code broken.

[Dhaiven]

I said the same thing to myself but i think it's better to keep logic between Vector & AABB.
Vector is immutable and don't have a copy on the name of function return a new vector like add so i thinks it's better to do the same in AABB

[Dhaiven]

Maybe add @deprecated for *Copy versions and remove them for pmmp 7 for exemple

[dktapps]

I said the same thing to myself but i think it's better to keep logic between Vector & AABB. Vector is immutable and don't have a copy on the name of function return a new vector like add so i thinks it's better to do the same in AABB

Vector isn't relevant to this code. Totally different API. If anything, I'd've preferred Vector methods to have Copy suffixes to make it clear how they behave. But again, not relevant.

Maybe add @deprecated for *Copy versions and remove them for pmmp 7 for exemple

I don't want to penalize correct code. There's no point doing a deprecation like that, it's just delaying the inevitable.
Either we keep them permanently, or we remove them now.

If we remove the *Copy() variations

• bad (mutable) code silently gets a behavioural BC break and possibly stops working
• good (immutable) code blows up and has to be refactored for no good reason

If we just remove the mutable variants and keep *Copy()

• bad (mutable) code blows up and has to be refactored (fine)
• good (immutable) code is unaffected

[dktapps]

There are now many incorrect @return $this doc comments

[dktapps]

Looking better, but I think the docs could be cleaned up

Outsets the bounds of this AxisAlignedBB by the specified X, Y and Z.

Returns an expanded clone of this AxisAlignedBB.

can be reworded like

Returns a copy of the AxisAlignedBB with bounds outset by the specified X, Y and Z.

etc