Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chacha circuit #74

Merged
merged 10 commits into from
Dec 5, 2024
Merged

fix: chacha circuit #74

merged 10 commits into from
Dec 5, 2024

Conversation

lonerapier
Copy link
Collaborator

@lonerapier lonerapier commented Dec 4, 2024

fixes AES and ChaCha circuit ciphertext check by only checking till plaintext length and not beyond.

@lonerapier
Copy link
Collaborator Author

another path to prevent this constraint blowup could be to leave this as it is, and compute ciphertext again outside the circuit. the original ciphertext should remain unchanged when computed for padded plaintext, so shouldn't create any security issues. But definitely need more discussion, if it's the right path.

Copy link
Contributor

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, will merge when all ci passes

@Autoparallel Autoparallel merged commit bfc120b into main Dec 5, 2024
3 checks passed
@Autoparallel Autoparallel deleted the fix/chacha-circuit branch December 5, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: preferable to have chacha take in bytes instead of bits.
2 participants