release: v0.6.0 #65
Merged
release: v0.6.0 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoparallel
force-pushed
the
release/v0-6-0
branch
from
ea91cd1 to
08edfb7
Compare
|
Branch is clean now, force push done! |
- adds CHANGELOG.md - bumps version - deletes extra builds - updates main.rs - updates circuits.json
* remove: extra HTTP material * remove: aes * fix: tests * remove: old `circuits.json` * cleanup: JSON * Delete json_nivc.circom * Delete extractor.circom * remove: unneeded utils * remove: more utils * consolidate bytes * fix: build
Autoparallel
force-pushed
the
release/v0-6-0
branch
from
bb52e7a to
fba474f
Compare
* fix: http headers max * fix: verify HTTP machine state at end
0xJepsen
reviewed
Dec 5, 2024
| } | ||
| for (var j = 0 ; j < 4 ; j++) { | ||
| bigEndianCiphertext[i*4 + j] <== toCiphertextBytes[i].words[j]; | ||
| bigEndianCiphertext[i*4 + j] <== isPadding[i * 4 + j] * (-1 - toCiphertextBytes[i].words[j]) + toCiphertextBytes[i].words[j]; // equal to: (isPadding[i * 4 + j] * (-1)) + (1 - isPadding[i * 4 + j]) * toCiphertextBytes[i].words[j]; |
0xJepsen
approved these changes
Dec 5, 2024
0xJepsen
reviewed
Dec 5, 2024
Makefile
Outdated
| @@ -20,7 +20,7 @@ build: | |||
| @set -e; | |||
| @for circuit in $(CIRCOM_FILES); do \ | |||
| echo "Processing $${circuit}..."; \ | |||
| circom "$${circuit}" --r1cs --wasm -o "$$(dirname $${circuit})/artifacts" -l node_modules; \ | |||
| circom "$${circuit}" --r1cs --wasm --O1 -o "$$(dirname $${circuit})/artifacts" -l node_modules; \ | |||
lonerapier
requested changes
Dec 5, 2024
There was a problem hiding this comment.
sleep score after this PR lands: 10 -> 90
Seriously, so much of this is just dead weight. Thanks for spending time to clean this up thoroughly. this will also reduce amount of TODOs significantly.
I have really really minor nits along with following questions:
- Can we remove dead docs from
docs/and README?
a. Can we also add new really small doc for NIVC circuits? Can be totally done in a separate PR. Actually, i'll myself really love to do that. - Circuit sizes is really huge right now, and it's for all circuits. My suspicion is on
DataHasher, because that is only new common thing added to all circuits. Anyways, we should definitely check and bench the constraint size and r1cs size of circuit. (I am happy to do that) - Can we remove unused example files in
examples/directory?
| @@ -0,0 +1,73 @@ | |||
|
|
|||
There was a problem hiding this comment.
will the changelog be manually updated for each major revision?
lonerapier
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Staging
Tasks:
1024b(do we all agree?)step_in#53fix: constrain HTTP and JSON to have valid structure #56(I did this for HTTP, but not for JSON. It is problematic in JSON and I will do this in v0.7)-1instead of0#60